feat(reports): add auth proxy protecting report generators #206
+363
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204
Fixes #207
The end result should be that, if a report generator deployment is created (
--set reports.replicas=n
, wheren>0
), then requests sent to these Pods or the Service in front of them will require the client to pass an HTTP Basic authentication check. This check uses a hardcoded username, but a generated secret for a password. This helps prevent abuse of the report generator by other cluster workloads asking the report generator to process JFR files when they are not part of the Cryostat deployment.To test:
--set reports.replicas=1
to configure a report generator deployment.localhost:0
custom target, and request an automated analysis reportkubectl exec
on ex. the Cryostat container) and docurl -vk http://cryostat-reports.mynamespace.svc:10001/report
. Change the scheme tohttps
if deployed with OpenShift authentication enabled. This should result in an HTTP 403.