fixed final corrections

cryostatio · Aug 16, 2023 · 3f6ccf5 · 3f6ccf5
1 parent e6d1513
commit 3f6ccf5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/src/main/java/io/cryostat/recordings/RecordingTargetHelper.java b/src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
@@ -154,10 +154,7 @@ public IRecordingDescriptor startRecording(
                             if (isRecordingStopped(previous.get())) {
                                 connection.getService().close(previous.get());
                             } else {
-                                // If recording exists and running, stop and close it before
-                                // starting a
-                                // new one
-                                connection.getService().stop(previous.get());
+                                // If recording exists & running, close it before starting new one
                                 connection.getService().close(previous.get());
                             }
                         } else {

diff --git a/src/test/java/io/cryostat/net/web/http/api/v1/TargetRecordingsPostHandlerTest.java b/src/test/java/io/cryostat/net/web/http/api/v1/TargetRecordingsPostHandlerTest.java
@@ -558,7 +558,6 @@ void shouldStartRecordingAndArchiveOnStop() throws Exception {
         IRecordingDescriptor descriptor = createDescriptor("someRecording");
         Mockito.when(
                         recordingTargetHelper.startRecording(
-                                // Mockito.anyBoolean(),
                                 Mockito.any(),
                                 Mockito.any(),
                                 Mockito.any(),

diff --git a/src/test/java/io/cryostat/recordings/RecordingTargetHelperTest.java b/src/test/java/io/cryostat/recordings/RecordingTargetHelperTest.java
@@ -847,7 +847,7 @@ void shouldReplaceExistingRecording() throws Exception {
     }
 
     @Test
-    void shouldStopAndRecreateIfRecordingExistsAndIsRunning() throws Exception {
+    void shouldCloseAndRecreateIfRecordingExistsAndIsRunning() throws Exception {
         String recordingName = "existingRecording";
         String targetId = "fooTarget";
         String duration = "5000ms";
@@ -901,7 +901,6 @@ void shouldStopAndRecreateIfRecordingExistsAndIsRunning() throws Exception {
                 metadata,
                 false);
 
-        Mockito.verify(service).stop(existingRecording);
         Mockito.verify(service).close(existingRecording);
         Mockito.verify(service).start(Mockito.any(), Mockito.any());
     }