added updateRecordingOprtions: help needed to debug

cryostatio · Sep 7, 2023 · 942c548 · 942c548
1 parent 63fbd5b
commit 942c548
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 3 deletions.
diff --git a/src/main/java/io/cryostat/net/AgentClient.java b/src/main/java/io/cryostat/net/AgentClient.java
@@ -155,6 +155,32 @@ Future<IRecordingDescriptor> startSnapshot() {
                 });
     }
 
+    Future<Void> updateRecordingOptions(long id, IConstrainedMap<String> newSettings) {
+
+        JsonObject jsonSettings = new JsonObject();
+        for (String key : newSettings.keySet()) {
+            jsonSettings.put(key, newSettings.get(key));
+        }
+        Future<HttpResponse<Void>> f =
+                invoke(
+                        HttpMethod.PATCH,
+                        String.format("/recordings/%d", id),
+                        jsonSettings.toBuffer(),
+                        BodyCodec.none());
+
+        return f.map(
+                resp -> {
+                    int statusCode = resp.statusCode();
+                    if (HttpStatusCodeIdentifier.isSuccessCode(statusCode)) {
+                        return null;
+                    } else if (statusCode == 403) {
+                        throw new UnsupportedOperationException();
+                    } else {
+                        throw new RuntimeException("Unknown failure");
+                    }
+                });
+    }
+
     Future<Buffer> openStream(long id) {
         Future<HttpResponse<Buffer>> f =
                 invoke(HttpMethod.GET, "/recordings/" + id, BodyCodec.buffer());

diff --git a/src/main/java/io/cryostat/net/AgentJFRService.java b/src/main/java/io/cryostat/net/AgentJFRService.java
@@ -177,7 +177,7 @@ public IRecordingDescriptor getSnapshotRecording() throws FlightRecorderExceptio
         try {
             return client.startSnapshot().toCompletionStage().toCompletableFuture().get();
         } catch (ExecutionException | InterruptedException e) {
-            throw new FlightRecorderException("Failed to creat snapshot recording");
+            throw new FlightRecorderException("Failed to create snapshot recording", e);
         }
     }
 
@@ -249,9 +249,18 @@ public void updateEventOptions(IRecordingDescriptor arg0, IConstrainedMap<EventO
     }
 
     @Override
-    public void updateRecordingOptions(IRecordingDescriptor arg0, IConstrainedMap<String> arg1)
+    public void updateRecordingOptions(
+            IRecordingDescriptor recordingDescriptor, IConstrainedMap<String> newSettings)
             throws FlightRecorderException {
-        throw new UnimplementedException();
+        try {
+            long recordingId = recordingDescriptor.getId();
+            client.updateRecordingOptions(recordingId, newSettings)
+                    .toCompletionStage()
+                    .toCompletableFuture()
+                    .get();
+        } catch (ExecutionException | InterruptedException e) {
+            throw new FlightRecorderException("Failed to update recording options", e);
+        }
     }
 
     @Override