Skip to content

Commit

Permalink
fix(build): use vertx-dependencies and netty-bom for version manageme…
Browse files Browse the repository at this point in the history
…nt (#1720)
  • Loading branch information
andrewazores authored Oct 12, 2023
1 parent 7647d46 commit c1da58d
Showing 1 changed file with 22 additions and 10 deletions.
32 changes: 22 additions & 10 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,11 @@
<org.apache.commons.io.version>2.13.0</org.apache.commons.io.version>
<org.apache.httpcomponents.version>4.5.14</org.apache.httpcomponents.version>
<io.fabric8.client.version>6.7.2</io.fabric8.client.version>
<io.vertx.web.version>4.4.4</io.vertx.web.version>
<!-- https://repo1.maven.org/maven2/io/vertx/vertx-dependencies/${io.vertx.web.version}/vertx-dependencies-${io.vertx.web.version}.pom -->
<!-- https://groups.google.com/g/vertx/c/uzzcgw-YuOg -->
<io.netty.netty-transport-native-epoll.version>4.1.94.Final</io.netty.netty-transport-native-epoll.version><!-- FIXME this should be tied to the vertx version -->
<io.netty.version>4.1.94.Final</io.netty.version>
<io.vertx.version>4.4.4</io.vertx.version>
<!--
FIXME this needs to be synced with the vertx version - is there a BOM to use or something?
https://github.com/vert-x3/vertx-web/blob/${io.vertx.web.version}/vertx-web-graphql/pom.xml#L35
https://github.com/vert-x3/vertx-web/blob/${io.vertx.version}/vertx-web-graphql/pom.xml#L35
-->
<com.graphql.java.extended.scalars.version>20.2</com.graphql.java.extended.scalars.version>
<com.nimbusds.jose.jwt.version>9.31</com.nimbusds.jose.jwt.version>
Expand All @@ -127,6 +125,25 @@
<shellcheck-maven-plugin.version>0.5.1</shellcheck-maven-plugin.version>
</properties>

<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-bom</artifactId>
<version>${io.netty.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-dependencies</artifactId>
<version>${io.vertx.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>

<dependencies>
<dependency>
<groupId>io.cryostat</groupId>
Expand Down Expand Up @@ -181,17 +198,14 @@
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-web</artifactId>
<version>${io.vertx.web.version}</version>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-web-client</artifactId>
<version>${io.vertx.web.version}</version>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-web-graphql</artifactId>
<version>${io.vertx.web.version}</version>
</dependency>
<dependency>
<groupId>com.graphql-java</groupId>
Expand Down Expand Up @@ -1036,7 +1050,6 @@
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-epoll</artifactId>
<classifier>${io.netty.netty-transport-native-epoll.classifier}</classifier>
<version>${io.netty.netty-transport-native-epoll.version}</version>
<scope>${io.netty.netty-transport-native-epoll.scope}</scope>
</dependency>
</dependencies>
Expand All @@ -1057,7 +1070,6 @@
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-epoll</artifactId>
<classifier>${io.netty.netty-transport-native-epoll.classifier}</classifier>
<version>${io.netty.netty-transport-native-epoll.version}</version>
<scope>${io.netty.netty-transport-native-epoll.scope}</scope>
</dependency>
</dependencies>
Expand Down

0 comments on commit c1da58d

Please sign in to comment.