fix(discovery): retry failed target connections #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test image available: |
|
Test image available: |
andrewazores
force-pushed
the
retry-discovered-target-jmx
branch
from
bc7f5be
to
d84d94d
Compare
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
tthvo
reviewed
Jul 26, 2023
tthvo
reviewed
Jul 26, 2023
tthvo
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Looks good to me!!
I tested with a sample vertx deployment: https://gist.github.com/tthvo/d8a2b727953b1c47b6b7095de658496b. The target appears in discovery tree (i.e topology) but shows warning. Then sometime later, I can see the target is updated with a valid JVM ID.
andrewazores
force-pushed
the
retry-discovered-target-jmx
branch
from
9f93e2c
to
2fd8d2e
Compare
|
Test image available: |
|
Test image available: |
1 similar comment
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
andrewazores
force-pushed
the
retry-discovered-target-jmx
branch
from
2fd8d2e
to
282bfa9
Compare
tthvo
approved these changes
Jul 27, 2023
|
Test image available: |
|
Test image available: |
mergify bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
(cherry picked from commit bf86535) # Conflicts: # compose/compose-cryostat.yaml # compose/compose-vertx-jmx.yaml # smoketest-docker.sh # smoketest.sh
andrewazores
added a commit
that referenced
this pull request
Jul 27, 2023
* fix(discovery): retry failed target connections (#1593) (cherry picked from commit bf86535) # Conflicts: # compose/compose-cryostat.yaml # compose/compose-vertx-jmx.yaml # smoketest-docker.sh # smoketest.sh * cherrypick fixup * remove cherry-pick added unneeded files * fix podman discovery labels for older version --------- Co-authored-by: Andrew Azores <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes #1577