Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gh): update issue templates #1609

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

maxcao13
Copy link
Member

@maxcao13 maxcao13 commented Aug 9, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related: https://github.com/cryostatio/cryostat/issues/1269

Description of the change:

Updates the GH issue templates to fit the new beta GH issue forms to sync with -helm.

@maxcao13 maxcao13 added the chore Refactor, rename, cleanup, etc. label Aug 9, 2023
@mergify mergify bot added the safe-to-test label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1609-2982ba6fc7adb8c76e8252f961610ba1cc5035fd-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1609-2982ba6fc7adb8c76e8252f961610ba1cc5035fd-linux-arm64 sh smoketest.sh

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small comment.

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1609-ce4297c5a414578728fe1c47de9c895012307a12-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1609-ce4297c5a414578728fe1c47de9c895012307a12-linux-amd64 sh smoketest.sh

@andrewazores andrewazores merged commit d202690 into cryostatio:main Aug 10, 2023
19 checks passed
@maxcao13 maxcao13 deleted the update-gh-templates branch August 10, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants