-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(pom): restore dagger compiler property #1662
Merged
andrewazores
merged 3 commits into
cryostatio:main
from
ebaron:dagger-compiler-prop-restore
Sep 8, 2023
Merged
build(pom): restore dagger compiler property #1662
andrewazores
merged 3 commits into
cryostatio:main
from
ebaron:dagger-compiler-prop-restore
Sep 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliott Baron <[email protected]>
github-actions
bot
added
the
needs-triage
Needs thorough attention from code reviewers
label
Sep 8, 2023
andrewazores
removed
the
needs-triage
Needs thorough attention from code reviewers
label
Sep 8, 2023
andrewazores
reviewed
Sep 8, 2023
andrewazores
approved these changes
Sep 8, 2023
andrewazores
pushed a commit
that referenced
this pull request
Sep 13, 2023
* build(pom): restore dagger compiler property Signed-off-by: Elliott Baron <[email protected]> * Use dagger.version for property --------- Signed-off-by: Elliott Baron <[email protected]>
andrewazores
pushed a commit
that referenced
this pull request
Sep 13, 2023
* build(pom): restore dagger compiler property Signed-off-by: Elliott Baron <[email protected]> * Use dagger.version for property --------- Signed-off-by: Elliott Baron <[email protected]>
andrewazores
pushed a commit
that referenced
this pull request
Sep 15, 2023
* build(pom): restore dagger compiler property Signed-off-by: Elliott Baron <[email protected]> * Use dagger.version for property --------- Signed-off-by: Elliott Baron <[email protected]>
andrewazores
pushed a commit
that referenced
this pull request
Sep 18, 2023
* build(pom): restore dagger compiler property Signed-off-by: Elliott Baron <[email protected]> * Use dagger.version for property --------- Signed-off-by: Elliott Baron <[email protected]>
andrewazores
pushed a commit
that referenced
this pull request
Sep 18, 2023
* build(pom): restore dagger compiler property Signed-off-by: Elliott Baron <[email protected]> * Use dagger.version for property --------- Signed-off-by: Elliott Baron <[email protected]>
andrewazores
pushed a commit
that referenced
this pull request
Sep 19, 2023
* build(pom): restore dagger compiler property Signed-off-by: Elliott Baron <[email protected]> * Use dagger.version for property --------- Signed-off-by: Elliott Baron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Unfortunately, we still need these properties to be separate for downstream builds.
Related to: #1589