Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(pom): restore dagger compiler property #1662

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Sep 8, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Unfortunately, we still need these properties to be separate for downstream builds.

Related to: #1589

@ebaron ebaron added chore Refactor, rename, cleanup, etc. build labels Sep 8, 2023
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Sep 8, 2023
@mergify mergify bot added the safe-to-test label Sep 8, 2023
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Sep 8, 2023
pom.xml Outdated Show resolved Hide resolved
@andrewazores andrewazores merged commit 198c811 into cryostatio:main Sep 8, 2023
7 checks passed
andrewazores pushed a commit that referenced this pull request Sep 13, 2023
* build(pom): restore dagger compiler property

Signed-off-by: Elliott Baron <[email protected]>

* Use dagger.version for property

---------

Signed-off-by: Elliott Baron <[email protected]>
andrewazores pushed a commit that referenced this pull request Sep 13, 2023
* build(pom): restore dagger compiler property

Signed-off-by: Elliott Baron <[email protected]>

* Use dagger.version for property

---------

Signed-off-by: Elliott Baron <[email protected]>
andrewazores pushed a commit that referenced this pull request Sep 15, 2023
* build(pom): restore dagger compiler property

Signed-off-by: Elliott Baron <[email protected]>

* Use dagger.version for property

---------

Signed-off-by: Elliott Baron <[email protected]>
andrewazores pushed a commit that referenced this pull request Sep 18, 2023
* build(pom): restore dagger compiler property

Signed-off-by: Elliott Baron <[email protected]>

* Use dagger.version for property

---------

Signed-off-by: Elliott Baron <[email protected]>
andrewazores pushed a commit that referenced this pull request Sep 18, 2023
* build(pom): restore dagger compiler property

Signed-off-by: Elliott Baron <[email protected]>

* Use dagger.version for property

---------

Signed-off-by: Elliott Baron <[email protected]>
andrewazores pushed a commit that referenced this pull request Sep 19, 2023
* build(pom): restore dagger compiler property

Signed-off-by: Elliott Baron <[email protected]>

* Use dagger.version for property

---------

Signed-off-by: Elliott Baron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants