-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logging): exclude slf4j from vertx bom #1743
Merged
andrewazores
merged 1 commit into
cryostatio:main
from
andrewazores:vertx-slf4j-exclusion
Oct 25, 2023
Merged
fix(logging): exclude slf4j from vertx bom #1743
andrewazores
merged 1 commit into
cryostatio:main
from
andrewazores:vertx-slf4j-exclusion
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
added
dependencies
Pull requests that update a dependency file
fix
safe-to-test
labels
Oct 24, 2023
github-actions
bot
added
the
needs-triage
Needs thorough attention from code reviewers
label
Oct 24, 2023
andrewazores
changed the title
chore(pom): exclude slf4j from vertx bom
fix(logging): exclude slf4j from vertx bom
Oct 24, 2023
andrewazores
added
backport
and removed
needs-triage
Needs thorough attention from code reviewers
labels
Oct 24, 2023
7 tasks
aali309
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mwangggg
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 yay logs!
/build_test |
To run smoketest:
|
andrewazores
force-pushed
the
vertx-slf4j-exclusion
branch
from
October 24, 2023 20:29
75bbd03
to
365b24c
Compare
ebaron
approved these changes
Oct 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit f6b03ad)
andrewazores
added a commit
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit f6b03ad) Co-authored-by: Andrew Azores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1742
Description of the change:
Excludes slf4j artifacts from the vertx-dependencies bom. We define our own version and scopes.
Motivation for the change:
This restores missing log messages since #1720.
How to manually test: