fix(recordings): fix bug caused by #1692 #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mwangggg! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
|
Hi @mwangggg! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
andrewazores
changed the title
mwangggg
force-pushed
the
fix-jvmId-bug
branch
from
6934b0b
to
f381daf
Compare
|
/build_test |
|
Nice, very small fix after all. I tested this alongside cryostatio/cryostat-web#1127 and I now see that the web-client makes the requests to the server using the unencoded JVM ID, and then the server internally does the encoding/decoding to deal with the filesystem and completes the request. |
|
Looks like this needs a |
mwangggg
force-pushed
the
fix-jvmId-bug
branch
from
936a8f4
to
f428faa
Compare
andrewazores
approved these changes
Oct 30, 2023
andrewazores
pushed a commit
that referenced
this pull request
Oct 30, 2023
(cherry picked from commit d80f622) Co-authored-by: Ming Yu Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #1738
Related: #1731 #1692