fix(k8s): Endpoints discovery port names/numbers are configurable #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andrewazores! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
|
/build_test |
|
Workflow started at 1/23/2024, 2:09:59 PM. View Actions Run. |
To run smoketest: |
|
|
tthvo
reviewed
Jan 23, 2024
src/main/java/io/cryostat/platform/internal/KubeApiPlatformStrategy.java
Show resolved
Hide resolved
7 tasks
andrewazores
force-pushed
the
k8s-discovery-config
branch
from
7a60a05
to
8dcca34
Compare
andrewazores
force-pushed
the
k8s-discovery-config
branch
2 times, most recently
from
0b93d62
to
b0d98e9
Compare
|
/build_test |
|
Workflow started at 2/6/2024, 12:21:03 PM. View Actions Run. |
andrewazores
force-pushed
the
k8s-discovery-config
branch
from
b0d98e9
to
66251f7
Compare
|
/build_test |
|
Workflow started at 2/6/2024, 12:44:21 PM. View Actions Run. |
To run smoketest: |
|
|
aali309
approved these changes
Feb 6, 2024
ebaron
approved these changes
Feb 12, 2024
This reverts commit 9d47322.
andrewazores
force-pushed
the
k8s-discovery-config
branch
from
691a9bd
to
62c38c4
Compare
mergify bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
) (cherry picked from commit 838affd)
andrewazores
added a commit
that referenced
this pull request
Feb 12, 2024
) (#1874) (cherry picked from commit 838affd) Co-authored-by: Andrew Azores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #1861
Description of the change:
Adds environment variables for customizing the behaviour of the builtin k8s Endpoints discovery mechanism. Rather than always looking for ports named
jfr-jmxor numbered9091, this allows the deploying user to specify a list of acceptable names and a list of acceptable numbers that should be matched, both of them comma-separated. The names list can be set to the empty list by using the value-, and the number list can be set to the empty list by using the value0. If these variables are not defined or have empty values then they default to the singleton lists ofjfr-jmxand9091respectively, maintaining the previous behaviour.Motivation for the change:
For users deploying Cryostat into scenarios where a port named
jfr-jmxor numbered9091already exists for another purpose, this allows Cryostat to be dropped in with only minor configuration so that the Kubernetes Endpoints discovery mechanism can still be used, but does not mistakenly see non-JMX service ports as connectable targets when they really are not.How to manually test:
helm install cryostat --set core.image.repository=quay.io/andrewazores/cryostat --set core.image.tag=2.5.0-k8s-discovery-3 --set pvc.enabled=true --set core.route.enabled=true ./charts/cryostatmake sample_appto get aquarkus-testsample applicationoc edit deployment cryostatto set/editCRYOSTAT_DISCOVERY_K8S_PORT_NAMESandCRYOSTAT_DISCOVERY_K8S_PORT_NUMBERS, andoc edit service quarkus-testto change the port name/number on the sample app.