Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(smoketest): update quarkus pods env vars for agent HTTPS connection #1900

Closed
wants to merge 1 commit into from

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Apr 2, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to: cryostatio/cryostat-agent#141
Depends on cryostatio/cryostat-agent#257

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Hi @mwangggg! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Apr 2, 2024
@mergify mergify bot added the safe-to-test label Apr 2, 2024
@mwangggg mwangggg removed the needs-triage Needs thorough attention from code reviewers label Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Hi @mwangggg! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

1 similar comment
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Hi @mwangggg! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

This PR/issue depends on:

--env CRYOSTAT_AGENT_CALLBACK="http://localhost:9977/" \
--env CRYOSTAT_AGENT_WEBSERVER_TLS_KEYSTORE_PASS="/certs/keystore.pass" \
--env CRYOSTAT_AGENT_WEBSERVER_TLS_KEYSTORE_FILE="/certs/crysotat-keystore.p12" \
--env CRYOSTAT_AGENT_WEBSERVER_TLS_CERT_FILE="/certs/server.cer" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the quarkus-test application is going to have certs added to it like this, then the cert should either be embedded into the application build itself (not coming from the agent, but rather the combination of raw application plus agent into a container image), or the cert should be overlaid on top of the application container image by using a --mount like in run.sh. If you go the --mount way then the certificate used can actually be generated within the smoketest script, or the script can check if a cert exists in some local directory.

@mwangggg mwangggg closed this Apr 16, 2024
@mwangggg mwangggg deleted the 141-HTTPS-server-keystore branch June 27, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. dependent safe-to-test test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants