-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(smoketest): update quarkus pods env vars for agent HTTPS connection #1900
Conversation
Hi @mwangggg! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
Hi @mwangggg! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
1 similar comment
Hi @mwangggg! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
This PR/issue depends on:
|
--env CRYOSTAT_AGENT_CALLBACK="http://localhost:9977/" \ | ||
--env CRYOSTAT_AGENT_WEBSERVER_TLS_KEYSTORE_PASS="/certs/keystore.pass" \ | ||
--env CRYOSTAT_AGENT_WEBSERVER_TLS_KEYSTORE_FILE="/certs/crysotat-keystore.p12" \ | ||
--env CRYOSTAT_AGENT_WEBSERVER_TLS_CERT_FILE="/certs/server.cer" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the quarkus-test application is going to have certs added to it like this, then the cert should either be embedded into the application build itself (not coming from the agent, but rather the combination of raw application plus agent into a container image), or the cert should be overlaid on top of the application container image by using a --mount
like in run.sh
. If you go the --mount
way then the certificate used can actually be generated within the smoketest script, or the script can check if a cert exists in some local directory.
d595008
to
f671c89
Compare
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to: cryostatio/cryostat-agent#141
Depends on cryostatio/cryostat-agent#257