[Bug] Remove mentions of JMX in Credential Database

[tthvo]

Current Behavior

Currently, we are still mentioning JMX in Database Configirations

{
...omitted-output...
	// Options to configure the Cryostat application's JMX credentials database.
	// +optional
	// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="JMX Credentials Database Options"
	JmxCredentialsDatabaseOptions *JmxCredentialsDatabaseOptions `json:"jmxCredentialsDatabaseOptions,omitempty"`
}

...omitted-output...

// JmxCredentialsDatabaseOptions provides configuration options to the Cryostat application's JMX credentials database.
type JmxCredentialsDatabaseOptions struct {
	// Name of the secret containing the password to encrypt JMX credentials database.
	// +optional
	// +operator-sdk:csv:customresourcedefinitions:type=spec,xDescriptors={"urn:alm:descriptor:io.kubernetes:Secret"}
	DatabaseSecretName *string `json:"databaseSecretName,omitempty"`
}

Expected Behavior

Credential Database is not only used for JMX credentials but also for Http-based Agent's.

cryostatio/cryostat-web#900

[tthvo]

For Upgrading from previous version to 2.3, I am just concerned about:

cryostat-operator/internal/controllers/secrets.go

Line 101 in 7cc914d

const jmxSecretNameSuffix = "-jmx-auth"

Updating this (also its keys too) will cause creation of new secret, right? Can we somehow migrate old secrets content?

Also, we will need a different field name for the Cryostat CRs. This needs some sort of "deprecated alias" for the old JMX- and keep both the old and new fields?

[ebaron]

I think this is fixed with #808