Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crd): remove mentions of JMX in credential database #575

Merged
merged 1 commit into from
May 2, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented May 2, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to #573

Description of the change:

Update user displayName and description of the credential database option field.

Screenshot from 2023-05-02 11-53-12

Though, with users creating or inspecting Cryostat with CLI. This descriptions are updated but the old field is visible.

$ oc explain cryostat.spec.jmxCredentialsDatabaseOptions
KIND:     Cryostat
VERSION:  operator.cryostat.io/v1beta1

RESOURCE: jmxCredentialsDatabaseOptions <Object>

DESCRIPTION:
     Options to configure the Cryostat application's credentials database.

FIELDS:
   databaseSecretName	<string>
     Name of the secret containing the password to encrypt credentials database.

Motivation for the change:

See #573

@ebaron ebaron merged commit dd8c8f0 into cryostatio:main May 2, 2023
mergify bot pushed a commit that referenced this pull request May 2, 2023
Signed-off-by: Thuan Vo <[email protected]>
(cherry picked from commit dd8c8f0)

# Conflicts:
#	bundle/manifests/cryostat-operator.clusterserviceversion.yaml
@tthvo tthvo deleted the cred-db branch May 2, 2023 19:15
ebaron pushed a commit that referenced this pull request May 2, 2023
… (#576)

* fix(crd): remove mentions of JMX in credential database (#575)

Signed-off-by: Thuan Vo <[email protected]>
(cherry picked from commit dd8c8f0)

# Conflicts:
#	bundle/manifests/cryostat-operator.clusterserviceversion.yaml

* resovle conflicts

---------

Co-authored-by: Thuan Vo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants