Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(scorecard): clean up images for both push and pr ci #620

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Aug 31, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to #603

Description of the change:

Previously only PR images are cleaned up. This will update workflow to clean up those test images right after the scored card test job.

Motivation for the change:

With these changes, test images are only available during the scorecard test process. All will be cleaned up right after tests are done. Works for both push and PR ci.

@tthvo tthvo added chore Refactor, rename, cleanup, etc. ci labels Aug 31, 2023
@mergify mergify bot added the safe-to-test label Aug 31, 2023
@andrewazores andrewazores merged commit 5c3769f into cryostatio:main Aug 31, 2023
21 of 27 checks passed
@tthvo tthvo deleted the cleanup-image branch October 17, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. ci safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants