Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): core resource requests split with sidecar #626

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Based on #617

Description of the change:

If there is no configuration for -reports sidecar(s), increase the resources requested for the main cryostat container instead.

Motivation for the change:

If the CR does not have any report generation configuration then the Cryostat server will fall back to generating reports itself by forking a subprocess within its container. This at least needs some memory allocation of its own and preferably some CPU time as well to complete its work in a reasonable time. So, in deployments like this, assign the maximum of the CPU and Memory requests that would go to either the core container or the reports container(s) to the core container so that the additional headroom may be used for subprocess report generation.

@andrewazores andrewazores added the feat New feature or request label Sep 12, 2023
@mergify mergify bot added the safe-to-test label Sep 12, 2023
@github-actions
Copy link

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant