Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): use separate deployment for Insights #962

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Oct 10, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #961
Depends on: cryostatio/cryostat-agent#510

Description of the change:

  • Removes Go module dependency on the Runtimes Inventory Operator
  • Adds a Kustomize overlay to optionally build a bundle that includes a second deployment for the Runtimes Inventory Operator container image with its own RBAC
  • Bumps Kustomize version to support Replacements

Motivation for the change:

  • Removes a Go module dependency that is only useful in downstream Red Hat builds
  • When enabled. the Insights integration no longer counts towards Cryostat Operator's resource limits

How to manually test:

  1. make bundle bundle-build ENABLE_INSIGHTS=true
  2. Deploy an agent sample app with -Drht.insights.java.debug=true
  3. Check for a line in the agent log like: Red Hat Insights - Payload was accepted for processing

@ebaron ebaron added the feat New feature or request label Oct 10, 2024
@ebaron ebaron requested a review from a team October 10, 2024 18:34
@ebaron ebaron requested a review from a team as a code owner October 10, 2024 18:34
@ebaron
Copy link
Member Author

ebaron commented Oct 10, 2024

/build_test

@mergify mergify bot added the safe-to-test label Oct 10, 2024
Copy link

/build_test completed successfully ✅.
View Actions Run.

Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ebaron ebaron merged commit c950764 into cryostatio:main Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Story] Use Runtimes Inventory Operator container image
2 participants