Skip to content

Commit

Permalink
resolved issues
Browse files Browse the repository at this point in the history
  • Loading branch information
aali309 committed May 23, 2024
1 parent 1ac93c2 commit 660cca2
Show file tree
Hide file tree
Showing 44 changed files with 199 additions and 199 deletions.
38 changes: 19 additions & 19 deletions locales/en/public.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
"AutomatedAnalysisCard": {
"CARD_DESCRIPTION": "Assess common application performance and configuration issues.",
"CARD_DESCRIPTION_FULL": "Creates a recording and periodically evaluates various common problems in application configuration and performance. Results are displayed with scores from 0-100 with colour coding and in groups. This card should be unique on a dashboard.",
"CARD_TITLE": "Automated Analysis",
"CARD_TITLE": "Automated analysis",
"CRITICAL_RESULTS_one": "{{count}} Critical Result",
"CRITICAL_RESULTS_other": "{{count}} Critical Results",
"ERROR_TEXT": "Cryostat was unable to generate an automated analysis report.",
"ERROR_TITLE": "Automated Analysis Error",
"ERROR_TITLE": "Automated analysis Error",
"GOOD_RESULTS": "No problems",
"NO_RESULTS": "No Results Found",
"NO_RESULTS_BODY": "No results match this filter criteria. Try removing filters, showing unavailable scores, or resetting the severity score filter to 0.",
Expand All @@ -37,7 +37,7 @@
"STALE_REPORT": {
"TEXT_one": "Most recent data from {{ count }} {{ units }} ago.",
"TEXT_other": "Most recent data from {{ count }} {{ units }}s ago.",
"TOOLTIP": "Report data is stale. Click the Create recording button and choose an option to start an active recording to source automated reports from."
"TOOLTIP": "Report data is stale. Click the Create Recording button and choose an option to start an active recording to source automated reports from."
},
"TOOLBAR": {
"CHECKBOX": {
Expand All @@ -48,7 +48,7 @@
"DELETE": {
"LABEL": "Delete automated analysis"
},
"LABEL": "Automated Analysis Toolbar",
"LABEL": "Automated analysis Toolbar",
"REFRESH": {
"LABEL": "Refresh automated analysis"
},
Expand All @@ -64,7 +64,7 @@
"AutomatedAnalysisConfigDrawer": {
"INPUT_GROUP": {
"CREATE_RECORDING": {
"LABEL": "Create recording"
"LABEL": "Create Recording"
},
"OPEN_SETTINGS": {
"LABEL": "Open Settings"
Expand All @@ -78,7 +78,7 @@
"MAXIMUM_AGE": "Maximum age ({{unit}})",
"MAXIMUM_SIZE": "Maximum size ({{unit}})",
"SAVE_CHANGES": "Save changes",
"TEMPLATE_HELPER_TEXT": "The Event template to be applied to Automated Analysis recordings.",
"TEMPLATE_HELPER_TEXT": "The Event Template to be applied to automated analysis recordings.",
"TEMPLATE_INVALID_WARNING": "WARNING: Setting a Target Template as a default template type configuration may not apply to all Target JVMs if the JVMs do not support them."
},
"AutomatedAnalysisScoreFilter": {
Expand Down Expand Up @@ -141,14 +141,14 @@
},
"TITLE": "{{chartKind}} (last {{duration}}s, every {{period}}s)"
},
"ClickableAutomatedAnalysisresult": {
"ClickableAutomatedAnalysisLabel": {
"ARIA_LABELS": {
"POPOVER": "cryostat_tmp"
"POPOVER": "automated-analysis-description-popover"
}
},
"Dashboard": {
"ADD_CARD_HELPER_TEXT": "Choose a card type to add to your dashboard. Some cards require additional configuration.",
"CARD_CATALOG_DESCRIPTION": "Cards added to this Dashboard layout present information at a glance about the selected target. The layout is preserved for all targets viewed on this client.",
"CARD_CATALOG_DESCRIPTION": "Cards added to this Dashboard Layout present information at a glance about the selected target. The layout is preserved for all targets viewed on this client.",
"CARD_CATALOG_TITLE": "Dashboard Card catalog",
"INVALID_CARD_CONFIGURATIONS": "Invalid Card configurations",
"PAGE_TITLE": "Dashboard"
Expand All @@ -157,23 +157,23 @@
"RESET_SIZE": "Reset size"
},
"DashboardLayoutCreateModal": {
"CREATE_LAYOUT": "Create Dashboard layout",
"CREATE_LAYOUT": "Create Dashboard Layout",
"ERROR": {
"NAME_INVALID": "Name must be alphanumeric and can contain underscores, dashes, and periods.",
"NAME_REQUIRED": "Layout name is a mandatory field.",
"NAME_TAKEN": "Specified layout name already exists.",
"NAME_TOO_LONG": "Name must be 20 characters or less."
},
"LABEL": "Create a new dashboard layout",
"LABEL": "Create a new Dashboard Layout",
"NAME": {
"HELPER_TEXT": "Enter a name for the Dashboard layout.",
"HELPER_TEXT": "Enter a name for the Dashboard Layout.",
"LABEL": "Name"
},
"RENAME_LAYOUT": "Rename Dashboard layout"
"RENAME_LAYOUT": "Rename Dashboard Layout"
},
"DashboardLayoutSetAsTemplateModal": {
"DOWNLOAD": {
"DESCRIPTION": "Download the current dashboard layout as a template.",
"DESCRIPTION": "Download the current Dashboard Layout as a template.",
"TITLE": "Download Custom Layout Template"
},
"ERROR": {
Expand All @@ -192,7 +192,7 @@
}
},
"SET_TEMPLATE": {
"DESCRIPTION": "Set the current dashboard layout as a template.",
"DESCRIPTION": "Set the current Dashboard Layout as a template.",
"TITLE": "Set Custom Layout Template"
}
},
Expand Down Expand Up @@ -267,7 +267,7 @@
"VERSION_INVALID": "Template version is invalid."
},
"HELP": {
"CONTENT": "Dashboard Layout Templates are pre-configured dashboard designs that can be used as a starting point for new dashboard layouts. Each template is defined in a JSON file that contains a list of dashboard cards and their configurations, as well as a unique name for the template. The name must be alphanumeric and can include underscores, dashes, and periods."
"CONTENT": "Dashboard Layout Templates are pre-configured dashboard designs that can be used as a starting point for new dashboard layouts. Each template is defined in a JSON file that contains a list of Dashboard Cards and their configurations, as well as a unique name for the template. The name must be alphanumeric and can include underscores, dashes, and periods."
},
"TITLE": "Upload Dashboard Layout Template"
},
Expand All @@ -293,8 +293,8 @@
"TITLE": "Auto-refresh"
},
"AUTOMATED_ANALYSIS_CONFIG": {
"DESCRIPTION": "Set the recording configuration for Automated Analysis recordings. You may want smaller or larger values for max-age and max-size depending on how recent you want events to be recorded from the analysis.",
"TITLE": "Automated Analysis recording configuration"
"DESCRIPTION": "Set the recording configuration for automated analysis recordings. You may want smaller or larger values for max-age and max-size depending on how recent you want events to be recorded from the analysis.",
"TITLE": "Automated analysis recording configuration"
},
"CATEGORIES": {
"ADVANCED": "Advanced",
Expand All @@ -310,7 +310,7 @@
},
"CREDENTIALS_STORAGE": {
"BACKEND": {
"DESCRIPTION": "Keep credentials in encrypted Cryostat backend storage. These credentials will be available to other users and will be used for Automated rules.",
"DESCRIPTION": "Keep credentials in encrypted Cryostat backend storage. These credentials will be available to other users and will be used for Automated Rules.",
"TITLE": "Backend"
},
"BROWSER_SESSION": {
Expand Down
2 changes: 1 addition & 1 deletion src/app/Agent/AgentProbeTemplates.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ export const AgentProbeTemplates: React.FC<AgentProbeTemplatesProps> = ({ agentD
id="templateFilter"
type="search"
placeholder="Filter..."
aria-label="Probe template filter"
aria-label="Probe Template filter"
onChange={setFilterText}
value={filterText}
/>
Expand Down
6 changes: 3 additions & 3 deletions src/app/CreateRecording/CreateRecording.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ export const CreateRecording: React.FC = () => {
);

return (
<TargetView pageTitle="Create recording" breadcrumbs={[{ title: 'Recordings', path: '/recordings' }]}>
<TargetView pageTitle="Create Recording" breadcrumbs={[{ title: 'Recordings', path: '/recordings' }]}>
<Card>
<CardBody>
<Tabs activeKey={activeTab} onSelect={onTabSelect}>
<Tab eventKey={0} title="Custom Flight recording">
<Tab eventKey={0} title="Custom Flight Recording">
<CustomRecordingForm />
</Tab>
<Tab eventKey={1} title="Snapshot recording">
<Tab eventKey={1} title="Snapshot Recording">
<SnapshotRecordingForm />
</Tab>
</Tabs>
Expand Down
4 changes: 2 additions & 2 deletions src/app/CreateRecording/CustomRecordingForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -543,11 +543,11 @@ export const CustomRecordingForm: React.FC = () => {
>
<Text component={TextVariants.small}>A value of 0 for maximum size or age means unbounded.</Text>
<FormGroup
fieldId="To Disk"
fieldId="To disk"
helperText="Write contents of buffer onto disk. If disabled, the buffer acts as circular buffer only keeping the most recent recording information"
>
<Checkbox
label="To Disk"
label="To disk"
id="toDisk-checkbox"
isChecked={formData.toDisk}
onChange={handleToDiskChange}
Expand Down
2 changes: 1 addition & 1 deletion src/app/CreateRecording/SnapshotRecordingForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const SnapshotRecordingForm: React.FC<SnapshotRecordingFormProps> = (_) =
<>
<Form isHorizontal>
<Text component={TextVariants.p}>
A Snapshot recording is one which contains all information about all events that have been captured in the
A Snapshot Recording is one which contains all information about all events that have been captured in the
current session by <i>other,&nbsp; non-Snapshot</i> recordings. Snapshots do not themselves define which
events are enabled, their thresholds, or any other options. A Snapshot is only ever in the STOPPED state from
the moment it is created.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export const AutomatedAnalysisCardList: React.FC<AutomatedAnalysisCardListProps>
return (
<OuterScrollContainer className="automated-analysis-datalist-outerscroll">
<InnerScrollContainer className="automated-analysis-datalist-innerscroll">
<TableComposable aria-label={'Automated Analysis Data List'} gridBreakPoint={'grid-md'} isStickyHeader>
<TableComposable aria-label={'Automated analysis Data List'} gridBreakPoint={'grid-md'} isStickyHeader>
<Thead>
<Tr>
<Th sort={getSortParams(0)}>{t('NAME', { ns: 'common' })}</Th>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export const AutomatedAnalysisFilters: React.FC<AutomatedAnalysisFiltersProps> =
case 'Topic':
return t('FILTER_TOPIC', { ns: 'common' });
default:
throw new Error(`Unknown Automated Analysis Filter Category: ${category}`);
throw new Error(`Unknown automated analysis filter category: ${category}`);
}
},
[t],
Expand Down
2 changes: 1 addition & 1 deletion src/app/Dashboard/DashboardSolo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const DashboardSolo: React.FC<DashboardSoloProps> = () => {
<EmptyState variant="large">
<EmptyStateIcon variant="container" component={MonitoringIcon} />
<Title headingLevel="h3" size="lg">
Dashboard card not found
Dashboard Card not found
</Title>
<EmptyStateBody>
Provide valid <code>layout</code> and <code>cardId</code> query parameters and try again.
Expand Down
2 changes: 1 addition & 1 deletion src/app/Dashboard/cryostat-dashboard-templates.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ const MemoryMonitoringLayout: LayoutTemplate = {
};

const AutomatedAnalysisLayout: LayoutTemplate = {
name: 'Automated Analysis',
name: 'Automated analysis',
description: 'A layout template for identifying and calculating risk scores for common performance issues in a JVM.',
vendor: LayoutTemplateVendor.CRYOSTAT,
cards: [
Expand Down
4 changes: 2 additions & 2 deletions src/app/Events/EventTemplates.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export const EventTemplates: React.FC<EventTemplatesProps> = (_) => {
(t: EventTemplate) => {
let actions = [
{
title: 'Create recording...',
title: 'Create Recording...',
onClick: () =>
navigate('/recordings/create', {
state: { template: { name: t.name, type: t.type } } as Partial<CustomRecordingFormData>,
Expand Down Expand Up @@ -356,7 +356,7 @@ export const EventTemplates: React.FC<EventTemplatesProps> = (_) => {
id="templateFilter"
type="search"
placeholder="Filter..."
aria-label="Event template filter"
aria-label="Event Template filter"
onChange={setFilterText}
value={filterText}
isDisabled={errorMessage != ''}
Expand Down
6 changes: 3 additions & 3 deletions src/app/Joyride/CryostatJoyride.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const CryostatJoyride: React.FC<CryostatJoyrideProps> = ({ children }) => {
use of <strong>Dashboard Cards</strong>.
</p>
<br />
<p>There are various dashboard cards that can be configured to display different metrics and charts.</p>
<p>There are various Dashboard Cards that can be configured to display different metrics and charts.</p>
</div>
),
target: '*[data-tour-id="dashboard"]',
Expand All @@ -108,10 +108,10 @@ const CryostatJoyride: React.FC<CryostatJoyrideProps> = ({ children }) => {
placement: 'right',
},
{
title: 'Automated rules',
title: 'Automated Rules',
content: (
<p>
Create, delete, enable, and view Cryostat <strong>Automated rules</strong> in this view. Automated rules
Create, delete, enable, and view Cryostat <strong>Automated Rules</strong> in this view. Automated Rules
allow you start recordings on target JVMs based on a set of conditions.
</p>
),
Expand Down
54 changes: 27 additions & 27 deletions src/app/Modal/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,55 +39,55 @@ export interface DeleteOrDisableWarning {
export const DeleteActiveRecordings: DeleteOrDisableWarning = {
id: DeleteOrDisableWarningType.DeleteActiveRecordings,
title: 'Permanently delete your JFR recording?',
label: 'Delete Active recording',
label: 'Delete Active Recording',
description: `If you click Delete, recording and report data will be lost.`,
ariaLabel: 'Recording delete warning',
};

export const DeleteArchivedRecordings: DeleteOrDisableWarning = {
id: DeleteOrDisableWarningType.DeleteArchivedRecordings,
title: 'Permanently delete your Archived JFR recording?',
label: 'Delete Archived recording',
label: 'Delete Archived Recording',
description: `If you click Delete, recording and report data will be lost.`,
ariaLabel: 'Recording delete warning',
};

export const DeleteAutomatedRules: DeleteOrDisableWarning = {
id: DeleteOrDisableWarningType.DeleteAutomatedRules,
title: 'Permanently delete your Automated rule?',
label: 'Delete Automated rule',
title: 'Permanently delete your Automated Rule?',
label: 'Delete Automated Rule',
description: `If you click Delete, rule data will be lost.`,
ariaLabel: 'Automated rule delete warning',
ariaLabel: 'Automated Rule delete warning',
};

export const DisableAutomatedRules: DeleteOrDisableWarning = {
id: DeleteOrDisableWarningType.DisableAutomatedRules,
title: 'Disable your Automated rule?',
label: 'Disable Automated rule',
title: 'Disable your Automated Rule?',
label: 'Disable Automated Rule',
description: `If you click Disable, the rule will be disabled.`,
ariaLabel: 'Automated rule disable warning',
ariaLabel: 'Automated Rule disable warning',
};

export const DeleteEventTemplates: DeleteOrDisableWarning = {
id: DeleteOrDisableWarningType.DeleteEventTemplates,
title: 'Permanently delete your Event template?',
label: 'Delete Event template',
title: 'Permanently delete your Event Template?',
label: 'Delete Event Template',
description: `If you click Delete, custom event template data will be lost.`,
ariaLabel: 'Event template delete warning',
ariaLabel: 'Event Template delete warning',
};

export const DeleteProbeTemplates: DeleteOrDisableWarning = {
id: DeleteOrDisableWarningType.DeleteProbeTemplates,
title: 'Permanently delete your Probe template?',
label: 'Delete Probe template',
description: `If you click Delete, custom Probe template data will be lost.`,
ariaLabel: 'Probe template delete warning',
title: 'Permanently delete your Probe Template?',
label: 'Delete Probe Template',
description: `If you click Delete, custom Probe Template data will be lost.`,
ariaLabel: 'Probe Template delete warning',
};

export const DeleteActiveProbes: DeleteOrDisableWarning = {
id: DeleteOrDisableWarningType.DeleteActiveProbes,
title: 'Permanently remove your active Probes from the target?',
label: 'Remove active Probes',
label: 'Remove Active Probes',
description: `If you click Delete, active Probes will be removed from the target.`,
ariaLabel: 'Active Probes remove warning',
};
Expand All @@ -110,26 +110,26 @@ export const DeleteCustomTargets: DeleteOrDisableWarning = {

export const DeleteDashboardLayout: DeleteOrDisableWarning = {
id: DeleteOrDisableWarningType.DeleteDashboardLayout,
title: 'Permanently delete your Dashboard layout?',
title: 'Permanently delete your Dashboard Layout?',
label: 'Delete Dashboard layouts',
description: `If you click Delete, Dashboard layout configuration data will be lost.`,
ariaLabel: 'Dashboard layout delete warning',
description: `If you click Delete, Dashboard Layout configuration data will be lost.`,
ariaLabel: 'Dashboard Layout delete warning',
};

export const ClearDashboardLayout: DeleteOrDisableWarning = {
id: DeleteOrDisableWarningType.ClearDashboardLayout,
title: 'Permanently clear your Dashboard layout?',
label: 'Clear Dashboard layout',
description: 'If you click Clear, all cards in the current Dashboard layout will be removed.',
ariaLabel: 'Dashboard layout clear warning',
title: 'Permanently clear your Dashboard Layout?',
label: 'Clear Dashboard Layout',
description: 'If you click Clear, all cards in the current Dashboard Layout will be removed.',
ariaLabel: 'Dashboard Layout clear warning',
};

export const DeleteLayoutTemplate: DeleteOrDisableWarning = {
id: DeleteOrDisableWarningType.DeleteLayoutTemplate,
title: 'Permanently delete your Layout template?',
label: 'Delete Layout template',
description: `If you click Delete, Layout template configuration data will be lost.`,
ariaLabel: 'Layout template delete warning',
title: 'Permanently delete your Layout Template?',
label: 'Delete Layout Template',
description: `If you click Delete, Layout Template configuration data will be lost.`,
ariaLabel: 'Layout Template delete warning',
};

export const DeleteWarningKinds: DeleteOrDisableWarning[] = [
Expand Down
2 changes: 1 addition & 1 deletion src/app/QuickStarts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ TODO: Fix this section when quick starts are categorized
[About]{{highlight nav-about-tab}}
[Dashboard]{{highlight nav-dashboard-tab}}
[Topology]{{highlight nav-topology-tab}}
[Automated rules]{{highlight nav-automatedrules-tab}}
[Automated Rules]{{highlight nav-automatedrules-tab}}
[Recordings]{{highlight nav-recordings-tab}}
[Archives]{{highlight nav-archives-tab}}
[Events]{{highlight nav-events-tab}}
Expand Down
Loading

0 comments on commit 660cca2

Please sign in to comment.