Skip to content

Commit

Permalink
feat(auth): remove auth negotiation and JMX credentials passthrough (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewazores authored Dec 21, 2023
1 parent 60f7b2b commit c4b70f5
Show file tree
Hide file tree
Showing 19 changed files with 113 additions and 821 deletions.
9 changes: 3 additions & 6 deletions src/app/AppLayout/AppLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import { NotificationCategory, Notification } from '@app/Shared/Services/api.typ
import { NotificationsContext } from '@app/Shared/Services/Notifications.service';
import { FeatureLevel } from '@app/Shared/Services/service.types';
import { ServiceContext } from '@app/Shared/Services/Services';
import { useLogin } from '@app/utils/hooks/useLogin';
import { useSubscriptions } from '@app/utils/hooks/useSubscriptions';
import { useTheme } from '@app/utils/hooks/useTheme';
import { saveToLocalStorage } from '@app/utils/LocalStorage';
Expand Down Expand Up @@ -106,7 +105,6 @@ export const AppLayout: React.FC<AppLayoutProps> = ({ children }) => {
const [showSslErrorModal, setShowSslErrorModal] = React.useState(false);
const [aboutModalOpen, setAboutModalOpen] = React.useState(false);
const [isNotificationDrawerExpanded, setNotificationDrawerExpanded] = React.useState(false);
const showUserIcon = useLogin();
const [showUserInfoDropdown, setShowUserInfoDropdown] = React.useState(false);
const [showHelpDropdown, setShowHelpDropdown] = React.useState(false);
const [username, setUsername] = React.useState('');
Expand Down Expand Up @@ -417,7 +415,7 @@ export const AppLayout: React.FC<AppLayoutProps> = ({ children }) => {
/>
</ToolbarItem>
</ToolbarGroup>
<ToolbarItem visibility={{ default: showUserIcon ? 'visible' : 'hidden' }}>
<ToolbarItem visibility={{ default: 'visible' }}>
<Dropdown
isPlain
onSelect={() => setShowUserInfoDropdown(false)}
Expand All @@ -439,7 +437,6 @@ export const AppLayout: React.FC<AppLayoutProps> = ({ children }) => {
handleNotificationCenterToggle,
handleHelpToggle,
setShowUserInfoDropdown,
showUserIcon,
showUserInfoDropdown,
showHelpDropdown,
UserInfoToggle,
Expand Down Expand Up @@ -553,11 +550,11 @@ export const AppLayout: React.FC<AppLayoutProps> = ({ children }) => {
);

React.useEffect(() => {
if (showUserIcon && isAssetNew(build.version)) {
if (isAssetNew(build.version)) {
handleOpenGuidedTour();
saveToLocalStorage('ASSET_VERSION', build.version);
}
}, [handleOpenGuidedTour, showUserIcon]);
}, [handleOpenGuidedTour]);

return (
<GlobalQuickStartDrawer>
Expand Down
124 changes: 0 additions & 124 deletions src/app/Login/BasicAuthForm.tsx

This file was deleted.

105 changes: 0 additions & 105 deletions src/app/Login/Login.tsx

This file was deleted.

31 changes: 0 additions & 31 deletions src/app/Login/NoopAuthForm.tsx

This file was deleted.

84 changes: 0 additions & 84 deletions src/app/Login/OpenShiftPlaceholderAuthForm.tsx

This file was deleted.

Loading

0 comments on commit c4b70f5

Please sign in to comment.