chore(match expression): visualizer should have title #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test image available: |
tthvo
reviewed
Jul 17, 2023
|
Test image available: |
tthvo
reviewed
Jul 17, 2023
tthvo
reviewed
Jul 17, 2023
|
Test image available: |
aali309
force-pushed
the
match_expression_visualizer_title
branch
2 times, most recently
from
2364ddd
to
09048a6
Compare
|
Test image available: |
tthvo
previously approved these changes
Jul 17, 2023
|
Test image available: |
tthvo
previously approved these changes
Jul 17, 2023
aali309
force-pushed
the
match_expression_visualizer_title
branch
3 times, most recently
from
fbf3860
to
87607b9
Compare
aali309
force-pushed
the
match_expression_visualizer_title
branch
from
87607b9
to
13db028
Compare
|
Test image available: |
|
Test image available: |
tthvo
approved these changes
Jul 23, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
(cherry picked from commit 9ed8cb1)
|
Test image available: |
andrewazores
pushed a commit
that referenced
this pull request
Jul 25, 2023
(cherry picked from commit 9ed8cb1) Co-authored-by: Atif Ali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: #1041
Description of the change:
This change adds a title at the top of the page for the card that contains the Match Expression Visualizer.
Motivation for the change:
This change is helpful as suggested by doc team. The title will help users that comes across the word Match Expression Visualizer in documentations to figure out what the UI element it is referring to.
How to manually test: