chore(ts): fix typescript type-checking errors #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
|
Also, sorta odd that Mbean Metrics snapshots were removed in the source code. Added back now. |
|
Test image available: |
tthvo
force-pushed
the
ts-typecheck
branch
3 times, most recently
from
f96cdab
to
0d680b7
Compare
|
References: patternfly/patternfly-react-seed#94 |
|
Test image available: |
Signed-off-by: Thuan Vo <[email protected]>
|
Test image available: |
|
Test image available: |
|
Test image available: |
andrewazores
approved these changes
Aug 15, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Thuan Vo <[email protected]> (cherry picked from commit 5aa3f5c) # Conflicts: # .github/workflows/ci.yaml # package.json # src/app/Settings/SettingsUtils.ts # src/app/Topology/Shared/utils.tsx # src/test/Rules/CreateRule.test.tsx
andrewazores
pushed a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Thuan Vo <[email protected]> (cherry picked from commit 5aa3f5c) # Conflicts: # .github/workflows/ci.yaml # package.json # src/app/Settings/SettingsUtils.ts # src/app/Topology/Shared/utils.tsx # src/test/Rules/CreateRule.test.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to #689
Description of the change:
Added Typescript type-checking to ensure correct typings. Also, run this type checking in CI on pull request.
As for Mirage JS, I kept the type as
anyto represent unknown shapes of parsed objects returned from API server.Motivation for the change:
Help catch mismatched types when defining interfaces, types and creating object. This helps avoiding potential bugs (i.e. a field missing or extra fields are added).