Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(credentials): clean up UI text (backport #1139) #1144

Merged
merged 1 commit into from
Oct 23, 2023
Merged

chore(credentials): clean up UI text (backport #1139) #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/app/SecurityPanel/Credentials/StoreCredentials.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
DropdownToggleCheckbox,
EmptyState,
EmptyStateIcon,
Icon,

Check warning on line 35 in src/app/SecurityPanel/Credentials/StoreCredentials.tsx

View workflow job for this annotation

GitHub Actions / eslint-check (16.x) 

'Icon' is defined but never used

Check warning on line 35 in src/app/SecurityPanel/Credentials/StoreCredentials.tsx

View workflow job for this annotation

GitHub Actions / eslint-check (18.x) 

'Icon' is defined but never used
Popover,
Text,
TextContent,
Expand All @@ -41,7 +41,7 @@
Toolbar,
ToolbarContent,
ToolbarItem,
Tooltip,

Check warning on line 44 in src/app/SecurityPanel/Credentials/StoreCredentials.tsx

View workflow job for this annotation

GitHub Actions / eslint-check (16.x) 

'Tooltip' is defined but never used

Check warning on line 44 in src/app/SecurityPanel/Credentials/StoreCredentials.tsx

View workflow job for this annotation

GitHub Actions / eslint-check (18.x) 

'Tooltip' is defined but never used
} from '@patternfly/react-core';
import { OutlinedQuestionCircleIcon, SearchIcon } from '@patternfly/react-icons';
import { ExpandableRowContent, TableComposable, Tbody, Td, Th, Thead, Tr } from '@patternfly/react-table';
Expand Down Expand Up @@ -536,11 +536,12 @@
description: (
<TextContent>
<Text component={TextVariants.small}>
Credentials that Cryostat uses to connect to Cryostat agents or target JVMs over JMX are stored here. These are
stored in encrypted storage managed by the Cryostat backend. These credentials may be used for manually managing
recordings and event templates on target JVMs, as well as for Automated Rules which run in the background and
open unattended target connections. Any locally-stored client credentials held by your browser session are not
displayed here. See <Link to="/settings">Settings</Link> to configure locally-stored credentials.
Credentials that Cryostat uses to connect to Cryostat agents or target JVMs over JMX are stored in encrypted
storage.
</Text>
<Text component={TextVariants.small}>
The locally-stored client credentials held by your browser session are not displayed here. See{' '}
<Link to="/settings?tab=advanced">Settings</Link> to configure locally-stored credentials.
</Text>
</TextContent>
),
Expand Down
5 changes: 5 additions & 0 deletions src/app/Shared/Components/JmxAuthDescription.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ export const JmxAuthDescription: React.FC<React.PropsWithChildren<DescriptionPro
<Text component={TextVariants.pre}>com.sun.management.jmxremote.login.config</Text>
</TextListItem>
</TextList>
<Text component={TextVariants.p}>
These authentication credentials are stored in encrypted storage managed by the Cryostat backend and used for
manually managing recordings and event templates on target JVMs, as well as for Automated Rules which run in the
background and open unattended target connections.
</Text>
</TextContent>
);
};
Loading