Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recording): API v3 downloads #1206

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jan 10, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat#2
Depends on cryostatio/cryostat#235

Description of the change:

Removes the old API V2.1 JWT download flow in favour of simply following the new API V3 download URL redirect flow.

Motivation for the change:

This restores the web UI's ability to download active and archived recording files with the new V3 API, which does not re-implement the previous JWT flow.

How to test:

See cryostatio/cryostat#235

Copy link

This PR/issue depends on:

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andrewazores andrewazores merged commit 361483a into cryostatio:main Jan 11, 2024
17 of 18 checks passed
@andrewazores andrewazores deleted the v3-recording-download branch January 11, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants