Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint): Migrate eslint to the new flat configuration format #1214

Merged
merged 6 commits into from
May 15, 2024
Merged

chore(eslint): Migrate eslint to the new flat configuration format #1214

merged 6 commits into from
May 15, 2024

Conversation

mwangggg
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #1130

@mwangggg mwangggg added the chore Refactor, rename, cleanup, etc. label Feb 12, 2024
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Feb 12, 2024
@mergify mergify bot added the safe-to-test label Feb 12, 2024
@mwangggg mwangggg removed the needs-triage Needs thorough attention from code reviewers label Feb 14, 2024
@mwangggg mwangggg marked this pull request as ready for review May 15, 2024 15:04
@mwangggg mwangggg requested a review from a team as a code owner May 15, 2024 15:04
andrewazores
andrewazores reviewed May 15, 2024
View reviewed changes
eslint.config.js Outdated Show resolved Hide resolved
andrewazores
andrewazores reviewed May 15, 2024
View reviewed changes
eslint.config.js Outdated Show resolved Hide resolved
@andrewazores
Copy link
Member

/build_test

@github-actions GitHub Actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1214-ab9f491156827e8147a86ea3ea0b409c2ecbea83 bash smoketest.bash # then open http://localhost:8080

@andrewazores andrewazores merged commit c133e6e into cryostatio:main May 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Use new eslint configuration file format
2 participants
@mwangggg @andrewazores