fix(graphql): emit notifications on server error response #1218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #65
Related to #410
Related to cryostatio/cryostat#11
Description of the change:
GraphQL queries which do not explicitly suppress notifications will emit a graphical notification box if there are GraphQL errors in the response.
Motivation for the change:
Previously, notifications would only be displayed if the GraphQL response status code was
4xx/5xx
. With this change,2xx
responses which contain a GraphQL error response will also display notifications. This provides the user (or developer) more information about what went wrong with the request.How to manually test: