-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): adjust GraphQL queries and models for updated server schema #1222
Conversation
Hi @andrewazores! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
This PR/issue depends on:
|
4765ac6
to
dcc22a5
Compare
5bd950b
to
8aec3ac
Compare
@aali309 could you take a look at updating the unit tests related to the archived recordings views from your recent PR? https://github.com/cryostatio/cryostat-web/actions/runs/8670862635/job/23779369922 Running |
Hmm nevermind, looks like it may have been just a merge issue. |
Sorry, there was a merge issue, somehow it didn't merge properly from the PR and my first manual attempt was wrong. I think I have corrected it now and there are indeed unit test failures. |
Also, "View in Grafana" on the Uploaded Archives view isn't working. I will help look into that one however, since it may be a similar issue to cryostatio/cryostat#324 on the server side. I tested it with that server side PR checked out as well and the other archived views have a working "View in Grafana", just not that one. I think it might be as simple as a JVM ID base64 encoding bug, or something like that. |
Ok I will look into it also and update you. |
/build_test |
Test image available:
|
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Includes:
Depends on cryostatio/cryostat#294
Description of the change:
This change adds allows a match expression example to be copied to the clipboard...
Motivation for the change:
This change is helpful because users may want to copy the example for easier use...
How to manually test: