fix(jmxauth): remove references to client-side localstorage JMX credential passthrough #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
jmx-credentials
branch
2 times, most recently
from
3b5ca0e
to
dd9e75d
Compare
andrewazores
force-pushed
the
jmx-credentials
branch
from
dd9e75d
to
6d84fa4
Compare
mwangggg
reviewed
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes #1239
Description of the change:
The
X-JMX-AuthenticationandX-JMX-Authorizationheaders were historically used by older Cryostat versions so that clients could supply these headers with API requests, and Cryostat would use them to set the JMX connection credentials when connection to target applications. Cryostat 3.0 does not implement this behaviour, so here references to it and the mechanism for selecting it are removed from the UI. It is no longer supported because it has been replaced by the server-side encrypted database/encrypted table for JMX credentials, which are more powerful due to the matchExpression mechanism, as well as more secure since they are encrypted at rest in the database rather than held in browser localStorage in plaintext.How to manually test: