Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): query target nodes by targets' IDs rather than connectUrls #1245

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 19, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1244
Depends on cryostatio/cryostat#342 (targetIds filter is added here)

Description of the change:

Updates GraphQL queries that act upon particular targets to do so by their IDs, rather than using the connectUrl as the node name filter.

Motivation for the change:

It is not guaranteed, and is not true for Cryostat Agent instances, that the discovery nodes' names are equal to their connection URLs. This fixes queries being unable to locate such nodes.

How to manually test:

  1. Combine with feat(agent): enable Agent HTTP communications cryostat#342
  2. Select quarkus-test-agent target
  3. Go to Recordings, create a new recording, wait a few moments, then archive it
  4. Click the Archived recordings tab. The recording should appear in the table

Copy link

This PR/issue depends on:

aali309
aali309 previously approved these changes Apr 22, 2024
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores marked this pull request as ready for review April 23, 2024 03:35
@andrewazores andrewazores merged commit 20dcce1 into cryostatio:main Apr 23, 2024
17 of 18 checks passed
@andrewazores andrewazores deleted the graphql-query-name-url branch April 23, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] GraphQL queries assume nodes' names equal their connection URLs
2 participants