fix(graphql): query target nodes by targets' IDs rather than connectUrls #1245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1244
Depends on cryostatio/cryostat#342 (
targetIds
filter is added here)Description of the change:
Updates GraphQL queries that act upon particular targets to do so by their IDs, rather than using the
connectUrl
as the node name filter.Motivation for the change:
It is not guaranteed, and is not true for Cryostat Agent instances, that the discovery nodes' names are equal to their connection URLs. This fixes queries being unable to locate such nodes.
How to manually test:
quarkus-test-agent
target