Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GraphQL): fix VallidationError: null ID for non-null BigInteger! #1256

Merged
merged 1 commit into from
May 7, 2024

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented May 7, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: 437

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

mentioned by @andrewazores on cryostatio/cryostat#437

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. Archive a recording and go to Archives -> All Targets and try to expand the table row corresponding to the related target. You should be able to see the archived recordings.

@aali309
Copy link
Contributor Author

aali309 commented May 7, 2024

/build_test

@andrewazores
Copy link
Member

Copy link

github-actions bot commented May 7, 2024

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1256-4f5a3930c46de14611e26386f6bdfadc95697a28 bash smoketest.bash # then open http://localhost:8080

@andrewazores andrewazores merged commit 2cffe0b into cryostatio:main May 7, 2024
23 checks passed
@aali309 aali309 deleted the fixNullID branch May 7, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] GraphQL ValidationError: null ID for non-null BigInteger!
2 participants