fix(demo): mirage demo fixups for 3.0 #1257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to cryostatio/cryostatio.github.io#176
Description of the change:
reportUrl
will be prefixed by the server's authority if it is not already. This ensures that the client cannot be fooled into making a request to another server than the one it is hosted on. This also fixes a bug in the Mirage report generationMotivation for the change:
Preparing the live demo for 3.0.
How to manually test:
yarn start:dev:preview
true
. But, you should be able to view Topology, Recordings, Events, and even create fake recordings on targets, view fake analysis reports on those recordings, stop/archive/delete recordings, etc.