Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(UI): match capitalization to match PF guide #1260

Merged
merged 13 commits into from
Jun 5, 2024

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented May 22, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1146

Description of the change:

This update ensures the UI adheres to the PatternFly design guidelines, promoting a consistent and user-friendly experience. https://www.patternfly.org/ux-writing/capitalization/

Motivation for the change:

see https://github.com//issues/1146

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@aali309 aali309 added the fix label May 22, 2024
@aali309 aali309 self-assigned this May 22, 2024
@mergify mergify bot added the safe-to-test label May 22, 2024
@aali309
Copy link
Contributor Author

aali309 commented May 22, 2024

@andrewazores Please whenever you have time, checkout on this PR and see if the changes make sense so far.

@aali309 aali309 marked this pull request as ready for review May 23, 2024 20:33
src/app/build.json Outdated Show resolved Hide resolved
src/mirage/index.ts Outdated Show resolved Hide resolved
@andrewazores
Copy link
Member

image

Should "Select a target" and "Filter by target..." use Target here?

@aali309
Copy link
Contributor Author

aali309 commented May 31, 2024

image

Should "Select a target" and "Filter by target..." use Target here?

Thinking about it, we dint capitalize target on cryostatio/cryostatio.github.io#153. However, for me Target makes more sense here!

@aali309 aali309 force-pushed the inconsistentCapitalization branch from dfe1423 to b55bade Compare June 3, 2024 13:44
@andrewazores
Copy link
Member

Rebase please

@aali309 aali309 force-pushed the inconsistentCapitalization branch from 86436ab to b1fd93f Compare June 4, 2024 23:55
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. docs and removed fix labels Jun 5, 2024
@andrewazores andrewazores changed the title fix(UI): match capitalization to match PF guide docs(UI): match capitalization to match PF guide Jun 5, 2024
@andrewazores andrewazores merged commit 9e21402 into cryostatio:main Jun 5, 2024
27 checks passed
@aali309 aali309 deleted the inconsistentCapitalization branch June 5, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. docs safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Inconsistent capitalization in in-app help menu
2 participants