-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(UI): match capitalization to match PF guide #1260
Merged
andrewazores
merged 13 commits into
cryostatio:main
from
aali309:inconsistentCapitalization
Jun 5, 2024
Merged
docs(UI): match capitalization to match PF guide #1260
andrewazores
merged 13 commits into
cryostatio:main
from
aali309:inconsistentCapitalization
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@andrewazores Please whenever you have time, checkout on this PR and see if the changes make sense so far. |
Thinking about it, we dint capitalize target on cryostatio/cryostatio.github.io#153. However, for me |
aali309
force-pushed
the
inconsistentCapitalization
branch
from
June 3, 2024 13:44
dfe1423
to
b55bade
Compare
Rebase please |
aali309
force-pushed
the
inconsistentCapitalization
branch
from
June 4, 2024 23:55
86436ab
to
b1fd93f
Compare
andrewazores
approved these changes
Jun 5, 2024
andrewazores
changed the title
fix(UI): match capitalization to match PF guide
docs(UI): match capitalization to match PF guide
Jun 5, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1146
Description of the change:
This update ensures the UI adheres to the PatternFly design guidelines, promoting a consistent and user-friendly experience. https://www.patternfly.org/ux-writing/capitalization/
Motivation for the change:
see https://github.com//issues/1146
How to manually test: