fix(auth): render username in top bar #1264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes cryostatio/cryostat#489
Related to cryostatio/cryostat#490
Description of the change:
If the response from the server includes the
Gap-Auth
header, use that to determine the user's logged in username. If not, fall back to using thePOST /api/v2.1/auth
response body. If anything is blank or fails then use the empty string, which the UI already renders as the anonymous user icon.How to manually test:
./smoketest.bash -O
user
appears on the top bar./smoketest.bash -Op
to disable the auth proxy