Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matchexpr): fix bug in evaluator List view (backport #1278) #1281

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 11, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1277

Description of the change:

The root of the bug is that the object passed in to the entity details view is the Target object itself, whereas it should be the Discovery TargetNode which contains the Target as a property.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

This is an automatic backport of pull request #1278 done by [Mergify](https://mergify.com).

Copy link

Hi @mergify[bot]! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@andrewazores andrewazores merged commit 9cc6acd into cryostat-v3.0 Jun 11, 2024
21 of 23 checks passed
@mergify mergify bot deleted the mergify/bp/cryostat-v3.0/pr-1278 branch June 11, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant