-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphql): improve error handling #1295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
reviewed
Jul 9, 2024
andrewazores
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few eslint warnings emitted:
andrewazores
changed the title
Fix GraphQL Exception handling
feat(graphql): improve error handling
Jul 10, 2024
There are a few test failures I'm working on resolving and I need to fix the snapshot tests as well. eslint and formatting issues are fixed |
andrewazores
reviewed
Aug 6, 2024
andrewazores
reviewed
Aug 6, 2024
…fic error handling integrated
andrewazores
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cryostatio/cryostat#394
Currently when graphQL queries fail due to missing SSL configuration or authentication failure the Web UI can't handle them correctly because they aren't throw in the traditional way. Rather than generating a 427 or 502 and accompanying HttpException they're instead masked by GraphQL and return a 200 but with a special response.
This response takes the form of an error object with various fields determined by the error handling configuration on the server. The accompanying cryostat3 PR changes this configuration to give us a form we can work with to determine the cause of the error and deal with it accordingly. With the server correctly configured this gives us the underlying exception and message, and the graphQL error classification (i.e. DataFetchingError).
This PR updates the graphQL queries and surrounding error handling to account for errors correctly and set the auth/ssl failure flags on the target accordingly.