Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): correct chart source url for jfr-metrics charts #1298

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jul 10, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1297

Description of the change:

  • Corrected chart source url construct for jft-metrics charts.
  • Fix Recording Start Time metric chart kind. Previously, throwing Invalid Value error (due to mismatched kind name).

image

Motivation for the change:

See #1297

@tthvo
Copy link
Member Author

tthvo commented Jul 10, 2024

/build_test

@andrewazores
Copy link
Member

/build_test

@andrewazores
Copy link
Member

Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1298-fc49e131687b0dd318b4bf1dc977ac9a7b4812fc bash smoketest.bash # then open http://localhost:8080

@andrewazores andrewazores merged commit 8fcd1e1 into cryostatio:main Jul 10, 2024
18 checks passed
mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@tthvo tthvo deleted the grafana-path branch July 10, 2024 14:30
andrewazores pushed a commit that referenced this pull request Jul 10, 2024
… (#1302)

Signed-off-by: Thuan Vo <[email protected]>
(cherry picked from commit 8fcd1e1)

Co-authored-by: Thuan Vo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] JFRMetrics Chart failed with invalid URL error
2 participants