Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(tools): emulate docker with podman before image builds #1300

Merged
merged 1 commit into from
Jul 10, 2024
Merged

ci(tools): emulate docker with podman before image builds #1300

merged 1 commit into from
Jul 10, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jul 10, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to #1290

Description of the change:

  • Emulate docker with podman before image build.

Motivation for the change:

#1290 didn't exactly solved the problem. docker was stilled used for building images.

@tthvo tthvo requested a review from a team July 10, 2024 08:16
@andrewazores andrewazores merged commit 2375375 into cryostatio:main Jul 10, 2024
26 of 27 checks passed
mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@tthvo @mergify
ci(tools): emulate docker with podman before image builds (#1300)
2a0bc13 
Signed-off-by: Thuan Vo <[email protected]>
(cherry picked from commit 2375375)
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
7 tasks
andrewazores pushed a commit that referenced this pull request Jul 10, 2024
@mergify @tthvo
ci(tools): emulate docker with podman before image builds (#1300) (#1301
c34f7dd 
)

Signed-off-by: Thuan Vo <[email protected]>
(cherry picked from commit 2375375)

Co-authored-by: Thuan Vo <[email protected]>
@tthvo tthvo deleted the pr-ci-build branch September 13, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
backport ci fix safe-to-test
Projects
4.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthvo @andrewazores