Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(topology): nodes can be filtered by label/annotation #1312

Merged
merged 14 commits into from
Jul 30, 2024
Merged

fix(topology): nodes can be filtered by label/annotation #1312

merged 14 commits into from
Jul 30, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #1311

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@andrewazores andrewazores mentioned this pull request Jul 30, 2024
Merged
7 tasks
@andrewazores andrewazores marked this pull request as ready for review July 30, 2024 16:30
tthvo
tthvo reviewed Jul 30, 2024
View reviewed changes
src/app/Topology/Shared/utils.tsx Outdated Show resolved Hide resolved
src/app/Topology/Toolbar/TopologyFilters.tsx Show resolved Hide resolved
src/app/Topology/Toolbar/TopologyFilters.tsx Outdated Show resolved Hide resolved
tthvo
tthvo approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@andrewazores andrewazores merged commit 9526cb5 into cryostatio:main Jul 30, 2024
18 checks passed
@andrewazores andrewazores deleted the gh1311 branch July 30, 2024 19:07
mergify bot pushed a commit that referenced this pull request Jul 30, 2024
@andrewazores @mergify
fix(topology): nodes can be filtered by label/annotation (#1312)
7d6d69a 
Signed-off-by: Andrew Azores <[email protected]>
Co-authored-by: Thuan Vo <[email protected]>
(cherry picked from commit 9526cb5)
@mergify mergify bot mentioned this pull request Jul 30, 2024
Merged
7 tasks
andrewazores added a commit that referenced this pull request Jul 30, 2024
@mergify @andrewazores
fix(topology): nodes can be filtered by label/annotation (#1312) (#1314)
70237a1 
Signed-off-by: Andrew Azores <[email protected]>
Co-authored-by: Thuan Vo <[email protected]>
(cherry picked from commit 9526cb5)

Co-authored-by: Andrew Azores <[email protected]>
@tthvo tthvo mentioned this pull request Jul 30, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo approved these changes

@aali309 aali309 Awaiting requested review from aali309

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
backport fix safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Label/Annotation filtering for target nodes is broken
2 participants
@andrewazores @tthvo