Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pf5): upgrade Recording view to Patternfly 5 #1318

Merged
merged 29 commits into from
Aug 14, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Aug 8, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1303

Description of the change:

Other upgrading the components to be compatible with PF5. Here some major and minor revamps.

Major changes

Changes Description Screenshot
New label editor for bulk editting Label editor is now following PF5 guideline and closer to that of OpenShift. The user can define labels with key=value. The same editor is used for Recording Form and Archive Upload. image

Minor changes

Changes Description Screenshot
Use a different color for advanced option labels Previously, a blue label can be confused as a selected label for filtering. image
Spacious AA content with refresh button now follows title A blue stripe on the left-end was removed in PF5, and action buttons should follow title instead. image
A vertical separator is added to separate filters and action buttons It is nicer look, especially when rendered with a checkbox (i.e. Continuous duration filter). image
Better wording and selected filter category should be indicated Selected item is now showed with a check mark. Duration unit is made clear. Redundant words are removed (i.e. "date"). image
Overflow menu item Stop is disabled if recording is already stopped Previously, this Stop button is not disabled and cause silently failed API call. image
Timezone picker now has its own section Timezone picker was given very limited space so menu toggle is significantly truncated. image
Use new icon button for label uploads This ensures the same upload button is used consistently across UI. image

@tthvo tthvo added chore Refactor, rename, cleanup, etc. safe-to-test labels Aug 8, 2024
@tthvo tthvo changed the title Pf5 recording chore(pf5): upgrade Recording view to Patternfly 5 Aug 8, 2024
@tthvo tthvo marked this pull request as ready for review August 10, 2024 03:53
@tthvo tthvo requested a review from a team August 10, 2024 03:54
@andrewazores
Copy link
Member

Wow, nice work. The screenshots of the updated design look excellent.

@andrewazores
Copy link
Member

Just rebase please - some of your other PRs are in pf5 now too since I merged main back into it, so there's conflicts here where you had already ported the changes in.

@tthvo
Copy link
Member Author

tthvo commented Aug 13, 2024

Just rebase please - some of your other PRs are in pf5 now too since I merged main back into it, so there's conflicts here where you had already ported the changes in.

Thanks! I rebased just now :D

@andrewazores andrewazores merged commit b6c4d70 into cryostatio:pf5 Aug 14, 2024
14 of 18 checks passed
@tthvo tthvo deleted the pf5-recording branch August 14, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants