-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pf5): upgrade Recording view to Patternfly 5 #1318
Conversation
Wow, nice work. The screenshots of the updated design look excellent. |
Just rebase please - some of your other PRs are in |
Thanks! I rebased just now :D |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #1303
Description of the change:
Other upgrading the components to be compatible with PF5. Here some major and minor revamps.
Major changes
key=value
. The same editor is used for Recording Form and Archive Upload.Minor changes
Stop
is disabled if recording is already stoppedStop
button is not disabled and cause silently failed API call.