Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(discovery): use target.agent field for determining connection type #1321

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1320
See cryostatio/cryostat#598

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. backport safe-to-test labels Aug 9, 2024
@mwangggg
Copy link
Member

mwangggg commented Aug 9, 2024

add to targetFactory and graphql query? Also, do we want a topology filter for the agent field?

@andrewazores
Copy link
Member Author

Also, do we want a topology filter for the agent field?

That would be nice.

@andrewazores andrewazores merged commit 09c7afc into cryostatio:main Aug 22, 2024
18 checks passed
@andrewazores andrewazores deleted the target-agent-field branch August 22, 2024 19:08
mergify bot pushed a commit that referenced this pull request Aug 22, 2024
andrewazores added a commit that referenced this pull request Aug 22, 2024
…ype (#1321) (#1332)

(cherry picked from commit 09c7afc)

Co-authored-by: Andrew Azores <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants