Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pf5): use new background image for About modal #1326

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Aug 12, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1303

Description of the change:

Added a new SVG asset to use as the About modal background. Since last time, I made the SVG dimmer (less opacity) to closely match the style of built-in SVG and cropped it a bit more.

Motivations

See #1303 (comment)

Others

I used this simple SVG editor from FlatHub: https://boxy-svg.com/

image

@tthvo tthvo added chore Refactor, rename, cleanup, etc. safe-to-test labels Aug 12, 2024
@tthvo tthvo requested a review from a team August 12, 2024 23:30
@andrewazores
Copy link
Member

Looks good, but tests are failing.

@tthvo
Copy link
Member Author

tthvo commented Aug 13, 2024

Looks good, but tests are failing.

Unfortunately, tests are failing everywhere on our pf5 base branch :(( lets fix it all together in a PR?

@andrewazores
Copy link
Member

Ah right, I didn't notice that this was targeting pf5.

@andrewazores andrewazores merged commit f6b34c7 into cryostatio:pf5 Aug 13, 2024
48 of 53 checks passed
@tthvo tthvo deleted the pf5-about branch August 13, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants