-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pf5): upgrade Settings view to Patternfly 5 #1330
Conversation
Uhhh opps, my bad ^^ Looks like we didn't escape the search text (seems to happen everywhere else too). It should be fixed now :D
Yep just did^^ |
In the latest commit, I added some css fixes for elements (i.e. those that were upgraded to PF5) to be compatible with dark theme. I think we can fix the rest while upgrading other remaining views :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @tthvo please take a quick look over the localizations I extracted in the last handful of commits.
Oh nicee! Looks good to me! Thanks for handling that :D |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #1303
Description of the change:
Minor changes
Major changes