Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pf5): upgrade Dashboard view to Patternfly 5 #1342

Merged
merged 23 commits into from
Sep 4, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Aug 31, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1303

Description of the change:

  • Upgrade Dashboard view to Patternfly 5.
  • Upgraded QuickStart to Patternfly 5
    • Only need to add missing imported css module for quickstart package.
    • Still there is a small bug with TIP admonition styling.
  • Moved common css style paths to a JS module to avoid having to change both places in webpack configs.
  • Updated Grafana dashboard panel's id. I organized the enum in order of increasing id (top down), similar to what being displayed on Grafana.

Minor changes

Changes Description Screenshot
Newly organized toolbar for Automatic Analysis Card Filter items are brought together. View mode is displayed as a toggle group (similar to theme toggle). Buttons also have tooltips now image
Sort is defaulted to Name There is no options to "unsort" (after selecting sort option) so it makes sense to just default to one. Template picker modal is now a bit large to allow spaces for previews image
Use CatalogTile component for dashboard selection This helps bring consistency with the template picker image

@tthvo tthvo added chore Refactor, rename, cleanup, etc. safe-to-test labels Aug 31, 2024
@tthvo tthvo requested a review from a team September 3, 2024 20:01
@tthvo tthvo marked this pull request as ready for review September 3, 2024 20:01
@tthvo
Copy link
Member Author

tthvo commented Sep 3, 2024

I think this is also ready now :D There are couple notes:

@tthvo
Copy link
Member Author

tthvo commented Sep 3, 2024

Thanks a lot to @maxcao13 for helping out on figuring out this upgrade too^^

@andrewazores andrewazores merged commit 4ca6d0b into cryostatio:pf5 Sep 4, 2024
14 of 18 checks passed
@tthvo tthvo deleted the pf5-dashboard branch September 6, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants