Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(about): add missing buildInfo in mocked health response #1345

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Sep 8, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1303 #1315

Description of the change:

  • Updated Mirage API mocks to include git commit hash.
  • Fixed Mirage /api/v2/targets API route to consider dryrun query parameter.
  • Fixed some remaining type-check issues.

Motivations

Previously, About page is throwing error in preview mode.

image

@tthvo tthvo added chore Refactor, rename, cleanup, etc. fix safe-to-test labels Sep 8, 2024
@tthvo tthvo requested a review from a team September 8, 2024 03:15
@tthvo tthvo changed the title chore(about): add missing buildInfo in mocked health response fix(about): add missing buildInfo in mocked health response Sep 8, 2024
@andrewazores andrewazores merged commit 3582233 into cryostatio:pf5 Sep 9, 2024
14 of 18 checks passed
@tthvo tthvo deleted the pf5-preview branch September 9, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. fix safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants