fix(pf5): allow menu footer to be sticky and use danger style for delete/clear buttons #1346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #1303
Description of the change:
maxMenuHeight
andisScrollable
where applicable.Delete
action, use "danger" style, following this guideline: https://www.patternfly.org/components/menus/menu/design-guidelines#red-text-menuMotivation for the change:
Previously, in order to view the action buttons at the menu footer, the user has to scroll all the way down. With these changes, the footer is always visible (i.e. sticky).
Ideally, the search bar should also be sticky. However, it does look like it is intended for the search bar to also scroll. See references:
Screenshots