Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pf5): allow menu footer to be sticky and use danger style for delete/clear buttons #1346

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Sep 8, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1303

Description of the change:

Motivation for the change:

Previously, in order to view the action buttons at the menu footer, the user has to scroll all the way down. With these changes, the footer is always visible (i.e. sticky).

Ideally, the search bar should also be sticky. However, it does look like it is intended for the search bar to also scroll. See references:

Screenshots

Description Screenshots
Sticky footer image
Danger-styled Delete/Clear Buttons (example from Rule table) image

@tthvo tthvo changed the title fix(pf5): allow menu footer to be sticky fix(pf5): allow menu footer to be sticky and use danger style for delete/clear buttons Sep 8, 2024
@tthvo tthvo marked this pull request as ready for review September 8, 2024 06:24
@tthvo tthvo requested a review from a team September 8, 2024 06:24
@andrewazores andrewazores merged commit fb87a10 into cryostatio:pf5 Sep 9, 2024
14 of 18 checks passed
@tthvo tthvo deleted the pf5-menu branch September 9, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants