Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storedcredentials): define target match array to avoid undefined reference error #1513

Merged

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: cryostatio/cryostat#756

Description of the change:

When a CredentialsStored notification is emitted, use the contents of that notification to patch the client-side model of the stored Credentials objects. The original returned value from the API response does not contain the real value, so this workaround keeps the UI in sync and avoids a t.targets is undefined error.

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. See [Bug] When creating a Credential, UI displays error with t.targets is undefined cryostat#756

@andrewazores andrewazores force-pushed the storedcredential-target-matches branch from b63af0b to 805972a Compare January 10, 2025 21:47
@andrewazores andrewazores merged commit a607a42 into cryostatio:main Jan 10, 2025
13 checks passed
@andrewazores andrewazores deleted the storedcredential-target-matches branch January 10, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] When creating a Credential, UI displays error with t.targets is undefined
2 participants