feat(i18n): allow setting i18n namespaces via an environment variable #1527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1526
Description of the change:
This change allows the i18n namespace(s) to be set as an environment variable.
To do so, I've added
useCryostatTranslation
to@i18n/i18nextUtil
which is justuseTranslation
with the required namespaces being set.I've also moved
i18nResources
andi18nLanguages
from@i18n/config
to@i18n/i18nextUtil
, because I was encountering issues where the Settings page was breaking on the Console plugin side and using a different i18n object than what the Console was expecting.I have a branch for the console plugin that includes some work to use these changes: aptmac/cryostat-openshift-console-plugin@c8d2d54
At the moment that branch is out of sync with upstream, I'll be fixing that up soon. That commit includes the ability to combine the cryostat-web
common
andpublic
with the console plugin sidecommon
, and renames it toplugin__cryostat-plugin
so it can be picked up by the Console.Motivation for the change:
This change is helpful because it will allow the console plugin to pass it's i18n namespace (something like
plugin__cryostat-plugin
) and allow the cryostat-web pages to access the localized strings.Before
(nothing changes for cryostat-web, but here's the console plugin):
After