fix(topology): listview target details need fixed height #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
changed the title
|
Test image available: |
tthvo
force-pushed
the
topology-listview
branch
from
379f104
to
f9f4391
Compare
|
Test image available: |
andrewazores
force-pushed
the
topology-listview
branch
from
f9f4391
to
5f492d2
Compare
andrewazores
force-pushed
the
topology-listview
branch
from
5f492d2
to
cbd2073
Compare
|
Test image available: |
andrewazores
approved these changes
Apr 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
(cherry picked from commit 2fa367b)
andrewazores
pushed a commit
that referenced
this pull request
Apr 25, 2023
(cherry picked from commit 2fa367b) Co-authored-by: Thuan Vo <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffRelated to #891
Description of the change:
Added a fixed height for entity detail in Topology List View. This allows list view to show JVM detail.
There was a fix for JVM Detail card in #937 but that PR missed the fix for Topology ListView.
Screenshots