ensure JVM ID is nulled if connection fails

cryostatio · Oct 23, 2024 · 6805f84 · 6805f84
1 parent d454e11
commit 6805f84
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/main/java/io/cryostat/targets/TargetJvmIdUpdateJob.java b/src/main/java/io/cryostat/targets/TargetJvmIdUpdateJob.java
@@ -63,8 +63,8 @@ private void updateTargetJvmId(long id) {
         QuarkusTransaction.requiringNew()
                 .run(
                         () -> {
+                            Target target = Target.getTargetById(id);
                             try {
-                                Target target = Target.getTargetById(id);
                                 target.jvmId =
                                         connectionManager
                                                 .executeDirect(
@@ -74,10 +74,11 @@ private void updateTargetJvmId(long id) {
                                                 .map(JvmIdentifier::getHash)
                                                 .await()
                                                 .atMost(connectionTimeout);
-                                target.persist();
                             } catch (Exception e) {
+                                target.jvmId = null;
                                 logger.error(e);
                             }
+                            target.persist();
                         });
     }
 }