Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GraphQL requests do not properly support custom auth/TLS error status codes #394

Closed
andrewazores opened this issue Apr 18, 2024 · 0 comments · Fixed by #554 or cryostatio/cryostat-web#1295
Assignees
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

andrewazores commented Apr 18, 2024

Current Behavior

#350 + #294

"Normal" HTTP API requests that result in a JMX auth failure or JMX SSL/TLS failure result in API response status codes 427 and 502, respectively. These trigger the web-client to display a modal informing the user what went wrong and how they can fix it. When these same failures occur within a GraphQL context however, this happens instead:

image

Expected Behavior

Either the GraphQL API response status code should match and be 427/502 directly, or else the web-client should know how to handle GraphQL responses, unwrap them, and treat them the same way as 427/502 responses.

This should not apply to the Topology view - here these warnings should be ignored and no modals should appear. Notifications might appear, but if it's feasible, they should be suppressed. Instead, the yellow warning indication decorators should appear on the affected targets, and clicking each target to examine it should reveal some information on how the user can handle the problem (similar to what the modal would do).

Steps To Reproduce

No response

Environment

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Status: Todo
2 participants