Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(discovery): plugin registration logging #677

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Oct 4, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat-agent#508

Description of the change:

Small logging changes, useful for troubleshooting registration failures.

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

Copy link

github-actions bot commented Oct 4, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mergify mergify bot added the safe-to-test label Oct 4, 2024
@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Oct 7, 2024
@andrewazores andrewazores marked this pull request as ready for review October 7, 2024 15:00
@andrewazores andrewazores requested a review from a team October 7, 2024 15:00
@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 10/15/2024, 4:21:23 PM. View Actions Run.

Copy link

No OpenAPI schema changes detected.

Copy link

No GraphQL schema changes detected.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/11353764745

@andrewazores andrewazores merged commit e45c0ee into cryostatio:main Oct 15, 2024
9 checks passed
@andrewazores andrewazores deleted the agent-registration branch October 15, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants