Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(discovery): plugin registration logging #677

Merged
merged 2 commits into from
Oct 15, 2024
Merged

chore(discovery): plugin registration logging #677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10aa083
log error before cleanup in case cleanup fails
andrewazores Oct 3, 2024
7f9a3d9
add debug log before testing plugin callback
andrewazores Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/io/cryostat/discovery/DiscoveryPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ public void prePersist(DiscoveryPlugin plugin) {
plugin.callback = UriBuilder.fromUri(plugin.callback).userInfo(null).build();
}
try {
logger.debugv(
"Testing discovery plugin callback: {0} @ {1}",
plugin.realm.name, plugin.callback);
PluginCallback.create(plugin).ping();
logger.debugv(
"Registered discovery plugin: {0} @ {1}",
Expand All @@ -118,8 +121,8 @@ public void prePersist(DiscoveryPlugin plugin) {
plugin.delete();
throw new IllegalArgumentException(e);
} catch (Exception e) {
plugin.delete();
logger.error("Discovery Plugin ping failed", e);
plugin.delete();
throw e;
}
}
Expand Down
Loading